Conversation
jancborchardt
added
3. to review
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @ChristophWurst and @juliabode to be potential reviewers. |
|
Also cc for review @juliabode @hechi because you worked on the sharing sidebar. :) |
|
Looks good 👍 |
| white-space: nowrap; | ||
| text-overflow: ellipsis; | ||
| max-width: 254px; | ||
| max-width: 110px !important; |
There was a problem hiding this comment.
Setting this to 80px also fixes it for german:
There was a problem hiding this comment.
But this only applies for screens smaller than ~1100px
|
Beside that it looks good - @jancborchardt could you add this for to the mobile.css? |
jancborchardt
force-pushed
the
sharing-layout
branch
from
5f3a1a9 to
cf1412e
Compare
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
sharing-layout
branch
from
cf1412e to
427c370
Compare
|
Fixed, please review again @MorrisJobke @rullzer @schiessle @nextcloud/designers :) |
| /* ellipsis on user names in share sidebar, less on mobile */ | ||
| #shareWithList .username { | ||
| max-width: 80px !important; | ||
| max-width: 80px !important; |
There was a problem hiding this comment.
This is still not used, because the one in sharetabview.css also has the !important
|
cc @icewind1991 |
|
👍 tested, works I would still like (for a separate PR) to have the |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
sharing-layout
branch
from
427c370 to
5eab1cd
Compare
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
…on with sharing Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
@icewind1991 fixed it, and more goodness. Please review @nextcloud/designers :) |
|
👍 |
5 participants
Before:
After:
Please review @nextcloud/designers @nextcloud/sharing